feat(hotkeys modal): ⚡ loading state + performance improvements#8694
Merged
lstein merged 4 commits intoinvoke-ai:mainfrom Dec 24, 2025
Merged
feat(hotkeys modal): ⚡ loading state + performance improvements#8694lstein merged 4 commits intoinvoke-ai:mainfrom
lstein merged 4 commits intoinvoke-ai:mainfrom
Conversation
lstein
approved these changes
Dec 24, 2025
Collaborator
lstein
left a comment
lstein
left a comment
There was a problem hiding this comment.
The older version didn't have performance issues on my system, but I've tested the new version and couldn't break it. No issues spotted in the code. I'm going to give this a thumbs-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With so many hotkey list items, each of which coming with a lot of functionality, the result is a modal that takes a full second or so to open. This PR contains some general performance improvements, and a loading state for the modal so it opens instantly while everything loads.
Added
Improved
Screencast_20251224_024858.webm
Related Issues / Discussions
QA Instructions
Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)